Skip to content

Extract FilterQueryBuilder to its own class #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented May 9, 2025

SearchBuilderBehavior is way too big and has too many responsibilities. This removes a chunk of them to its own class responsible for building only filter queries.

@jcoyne jcoyne force-pushed the extract-filter-query-builder branch from 53e608a to 8d036c4 Compare May 9, 2025 20:36
Copy link
Contributor

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jcoyne !

solr_parameters.append_filter_query(fq)
end
solr_parameters.merge!(subqueries) if subqueries
filter_query_builder_class_or_proc = filter.config.filter_query_builder || DefaultFilterQueryBuilder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like that this is configurable

@sandbergja sandbergja merged commit b38c792 into main May 28, 2025
11 checks passed
@sandbergja sandbergja deleted the extract-filter-query-builder branch May 28, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants